Fix auto-presentation on headset insertion

Fix auto-presentation on headset insertion

BUG=711480
Review-Url: https://codereview.chromium.org/2821433003
Cr-Commit-Position: refs/heads/master@{#464719}
Committed: https://chromium.googlesource.com/chromium/src/+/b83238b295c362e07efb4a6d8341843de63bd708

[mthiesse, 2017-04-13 22:30:45]

Description was changed from

==========
Fix auto-presentation on headset insertion

BUG=
==========

to

==========
Fix auto-presentation on headset insertion

BUG=711480
==========

[mthiesse, 2017-04-13 22:31:54]

Patchset #2 (id:20001) has been deleted

[mthiesse, 2017-04-13 22:32:28]

mthiesse@chromium.org changed reviewers:
+ bshe@chromium.org

[mthiesse, 2017-04-13 22:32:29]

PTAL

[bshe, 2017-04-13 22:55:29]

https://codereview.chromium.org/2821433003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2821433003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:143:
if (sInstance.mPaused) {
isn't mPaused always set to true when DON interrupt? And I assume we only
receive this broadcast after DON finished. So I am not sure I understand how
could this fix the issue?

[mthiesse, 2017-04-13 23:12:09]

Patchset #3 (id:60001) has been deleted

[mthiesse, 2017-04-13 23:13:38]

https://codereview.chromium.org/2821433003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2821433003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:143:
if (sInstance.mPaused) {
On 2017/04/13 22:55:29, bshe wrote:
> isn't mPaused always set to true when DON interrupt? And I assume we only
> receive this broadcast after DON finished. So I am not sure I understand how
> could this fix the issue?

It's subtle, so I added a comment. We don't get paused when calling launchInVr
in response to requestPresent during the daydream timeout, which happens when
the webVR page requestPresents in response to displayactivate.

[bshe, 2017-04-14 12:02:57]

On 2017/04/13 23:13:38, mthiesse wrote:
>
https://codereview.chromium.org/2821433003/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
> (right):
> 
>
https://codereview.chromium.org/2821433003/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:143:
> if (sInstance.mPaused) {
> On 2017/04/13 22:55:29, bshe wrote:
> > isn't mPaused always set to true when DON interrupt? And I assume we only
> > receive this broadcast after DON finished. So I am not sure I understand how
> > could this fix the issue?
> 
> It's subtle, so I added a comment. We don't get paused when calling launchInVr
> in response to requestPresent during the daydream timeout, which happens when
> the webVR page requestPresents in response to displayactivate.

I see. lgtm

[mthiesse, 2017-04-14 12:31:47]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2017-04-14 12:32:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 13:07:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492173107270600,
"parent_rev": "1e9fa3b2e7dca2ba228b9720570512676ed23798", "commit_rev":
"b83238b295c362e07efb4a6d8341843de63bd708"}

[commit-bot: I haz the power, 2017-04-14 13:08:30]

Description was changed from

==========
Fix auto-presentation on headset insertion

BUG=711480
==========

to

==========
Fix auto-presentation on headset insertion

BUG=711480

Review-Url: https://codereview.chromium.org/2821433003
Cr-Commit-Position: refs/heads/master@{#464719}
Committed:
https://chromium.googlesource.com/chromium/src/+/b83238b295c362e07efb4a6d8341...
==========

[commit-bot: I haz the power, 2017-04-14 13:08:31]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b83238b295c362e07efb4a6d8341...