Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2821343002: Image Capture Android: only restore preview parameters after photo is taken (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture Android: only restore preview parameters after photo is taken This CL introduces a member variable |mPreviewParameters| to cache the preview capture parameters in order to restore them after a picture is being taken and, more importantly (see bug), delays restoring those parameters until after the picture is actually taken. While debugging these changes with a Nexus 7 and a Galaxy Note 2 7100, I reckoned that the Nexus 7 is very delicate so I added some try-catches and avoided setting the picture resolution if not truly set by the user (== use preview size). BUG=706674 Review-Url: https://codereview.chromium.org/2826453002 Cr-Commit-Position: refs/heads/master@{#465118} (cherry picked from commit a6c1b9d6d636b72d9b88cb2ab5723be4770d006f) Review-Url: https://codereview.chromium.org/2821343002 . Cr-Commit-Position: refs/branch-heads/3071@{#35} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/a6f7ea59c5633ef2dc2708448487585a7cfdf23b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -35 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java View 4 chunks +40 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mcasas
3 years, 8 months ago (2017-04-18 17:20:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6f7ea59c5633ef2dc2708448487585a7cfdf23b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698