Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2821333003: Minimal patch to enable jumbo builds for blink core

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, dtapuska+blinkwatch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-paint_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, dshwang, apavlov+blink_chromium.org, pdr+renderingwatchlist_chromium.org, jchaffraix+rendering, Navid Zolghadr, blink-reviews, kozyatinskiy+blink_chromium.org, Mostyn Bramley-Moore
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minimal patch to enable jumbo builds for blink core This changes the common targets to use a jumbo build step which merges all the files in the target (excluding those excluded). More information at https://docs.google.com/document/d/19jGsZxh7DX8jkAKbL1nYBa5rcByUL2EeidnYsoXfsYQ/edit# BUG=713137 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Rebased patch (which made it smaller) #

Patch Set 3 : Added workaround for mac+goma problem. #

Patch Set 4 : Rebased and shrank the patch. #

Patch Set 5 : Rebased to current origin/master #

Patch Set 6 : Rebased to newer origin/master (nothing left) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/config/jumbo.gni View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (15 generated)
Daniel Bratell
Description was changed from ========== Minimal patch to enable jumbo builds for blink core and ...
3 years, 8 months ago (2017-04-19 11:33:01 UTC) #1
Daniel Bratell
The CQ bit was checked by bratell@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-19 11:36:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821333003/1
3 years, 8 months ago (2017-04-19 11:36:40 UTC) #3
Daniel Bratell
Description was changed from ========== Minimal patch to enable jumbo builds for blink core and ...
3 years, 8 months ago (2017-04-19 11:37:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-19 13:47:44 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-19 13:47:45 UTC) #6
Daniel Bratell
Description was changed from ========== Minimal patch to enable jumbo builds for blink core and ...
3 years, 8 months ago (2017-04-26 13:55:51 UTC) #7
Daniel Bratell
The CQ bit was checked by bratell@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-26 13:56:07 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821333003/1
3 years, 8 months ago (2017-04-26 13:56:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 15:29:35 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-26 15:29:36 UTC) #11
Daniel Bratell
The CQ bit was checked by bratell@opera.com to run a CQ dry run
3 years, 5 months ago (2017-06-27 15:51:01 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821333003/80001
3 years, 5 months ago (2017-06-27 15:51:12 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-06-27 16:34:45 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 16:34:45 UTC) #15 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698