Move the BreakCycle() method from the cycle solver to SVGResources

Move the BreakCycle() method from the cycle solver to SVGResources

This means we can get rid of the SVGResources::ResetFoo methods, and
thus the "friend"-ship between SVGResourcesCycleSolver and SVGResources.
This also reduces the dependencies between the cycle solver and specific
resource types.
Choose a more "semantic" name (ClearReferencesTo), and also remove the
unused DEBUG_CYCLE_DETECTION define.

Review-Url: https://codereview.chromium.org/2821333002
Cr-Commit-Position: refs/heads/master@{#465535}
Committed: https://chromium.googlesource.com/chromium/src/+/4f2cb99d84ed0aecd300a46bd6060254558e7c9d

[fs, 2017-04-18 17:14:26]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 17:14:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:14:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-04-18 19:24:28]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[pdr., 2017-04-19 02:06:56]

LGTM, nice cleanup!

[fs, 2017-04-19 08:45:03]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-04-19 08:45:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 08:49:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492591503777220, "parent_rev":
"209609c783ca7ae2eebdca677eae8ecab7266a90", "commit_rev":
"4f2cb99d84ed0aecd300a46bd6060254558e7c9d"}

[commit-bot: I haz the power, 2017-04-19 08:49:26]

Description was changed from

==========
Move the BreakCycle() method from the cycle solver to SVGResources

This means we can get rid of the SVGResources::ResetFoo methods, and
thus the "friend"-ship between SVGResourcesCycleSolver and SVGResources.
This also reduces the dependencies between the cycle solver and specific
resource types.
Choose a more "semantic" name (ClearReferencesTo), and also remove the
unused DEBUG_CYCLE_DETECTION define.
==========

to

==========
Move the BreakCycle() method from the cycle solver to SVGResources

This means we can get rid of the SVGResources::ResetFoo methods, and
thus the "friend"-ship between SVGResourcesCycleSolver and SVGResources.
This also reduces the dependencies between the cycle solver and specific
resource types.
Choose a more "semantic" name (ClearReferencesTo), and also remove the
unused DEBUG_CYCLE_DETECTION define.

Review-Url: https://codereview.chromium.org/2821333002
Cr-Commit-Position: refs/heads/master@{#465535}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f2cb99d84ed0aecd300a46bd606...
==========

[commit-bot: I haz the power, 2017-04-19 08:49:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f2cb99d84ed0aecd300a46bd606...