Allow the MITIGATION_WIN32K_DISABLE process mitigation to be set in the renderer sandbox.

Allow the MITIGATION_WIN32K_DISABLE process mitigation to be set in the renderer sandbox.

This is controllable by a command line switch "enable_gdi_user32_renderer_lockdown" at the moment.
Defaults to not being set.

BUG=365160
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271235

[jschuh, 2014-05-16 20:28:11]

https://codereview.chromium.org/282133007/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/282133007/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:438: =
"enable_gdi_user32_renderer_lockdown";
Could we just call these kEnableWin32kRendererLockDown and
enable_win32k_renderer_lockdown? That way they match the mitigation naming
convention.

https://codereview.chromium.org/282133007/diff/1/sandbox/win/src/process_miti...
File sandbox/win/src/process_mitigations.cc (right):

https://codereview.chromium.org/282133007/diff/1/sandbox/win/src/process_miti...
sandbox/win/src/process_mitigations.cc:311: MITIGATION_WIN32K_DISABLE |
Please remove MITIGATION_WIN32K_DISABLE here, because it's wrong (and my fault
:).

https://codereview.chromium.org/282133007/diff/1/sandbox/win/src/process_miti...
sandbox/win/src/process_mitigations.cc:318: return !(flags &
(MITIGATION_STRICT_HANDLE_CHECKS |
You'll need to update this test too:
https://code.google.com/p/chromium/codesearch#chromium/src/sandbox/win/src/pr...

Just remove the MITIGATION_WIN32K_DISABLE line in that file since it turns out
we weren't properly testing it anyway. I'll add coverage in later.

[ananta, 2014-05-16 21:12:18]

https://codereview.chromium.org/282133007/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/282133007/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:438: =
"enable_gdi_user32_renderer_lockdown";
On 2014/05/16 20:28:12, Justin Schuh wrote:
> Could we just call these kEnableWin32kRendererLockDown and
> enable_win32k_renderer_lockdown? That way they match the mitigation naming
> convention.

Done.

https://codereview.chromium.org/282133007/diff/1/sandbox/win/src/process_miti...
File sandbox/win/src/process_mitigations.cc (right):

https://codereview.chromium.org/282133007/diff/1/sandbox/win/src/process_miti...
sandbox/win/src/process_mitigations.cc:311: MITIGATION_WIN32K_DISABLE |
On 2014/05/16 20:28:12, Justin Schuh wrote:
> Please remove MITIGATION_WIN32K_DISABLE here, because it's wrong (and my fault
> :).

Done.

https://codereview.chromium.org/282133007/diff/1/sandbox/win/src/process_miti...
sandbox/win/src/process_mitigations.cc:318: return !(flags &
(MITIGATION_STRICT_HANDLE_CHECKS |
On 2014/05/16 20:28:12, Justin Schuh wrote:
> You'll need to update this test too:
>
https://code.google.com/p/chromium/codesearch#chromium/src/sandbox/win/src/pr...
> 
> Just remove the MITIGATION_WIN32K_DISABLE line in that file since it turns out
> we weren't properly testing it anyway. I'll add coverage in later.

Done.

[jschuh, 2014-05-16 21:15:03]

lgtm

[ananta, 2014-05-16 21:16:38]

+jam for content owners stamp.

[jam, 2014-05-16 21:27:31]

lgtm

[ananta, 2014-05-16 21:33:17]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:34:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/282133007/20001

[commit-bot: I haz the power, 2014-05-17 11:43:52]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[commit-bot: I haz the power, 2014-05-17 17:11:07]

Change committed as 271235