Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282133005: Removes unnecessary views::Widget::InitParams::top_level (Closed)

Created:
6 years, 7 months ago by pkotwicz
Modified:
6 years, 7 months ago
Reviewers:
benwells, sky
CC:
chromium-reviews, tdanderson+views_chromium.org, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, ben+views_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Removes unnecessary views::Widget::InitParams::top_level BUG=353533 TEST=None R=sky TBR=benwells (For trivial change to apps/ui/views/native_app_window_views.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272287

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -83 lines) Patch
M apps/ui/views/native_app_window_views.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/message_center/message_center_widget_delegate.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/examples/examples_window.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 5 chunks +3 lines, -9 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
pkotwicz
Scott, PTAL
6 years, 7 months ago (2014-05-16 01:52:44 UTC) #1
sky
Nice cleanup, LGTM
6 years, 7 months ago (2014-05-16 16:16:18 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-21 20:38:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/282133005/110001
6 years, 7 months ago (2014-05-21 20:39:12 UTC) #4
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-21 22:20:12 UTC) #5
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-21 22:20:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/282133005/110001
6 years, 7 months ago (2014-05-21 22:27:11 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 10:35:57 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 10:42:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155807)
6 years, 7 months ago (2014-05-22 10:42:07 UTC) #10
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-22 14:53:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/282133005/120001
6 years, 7 months ago (2014-05-22 14:55:24 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 19:56:32 UTC) #13
Message was sent while issue was closed. 
Change committed as 272287

Powered by Google App Engine
This is Rietveld 408576698