chrome/browser/ui/views/chrome_views_delegate_aura.cc - Issue 282133005: Removes unnecessary views::Widget::InitParams::top_level

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chrome_views_delegate_aura.cc

Issue 282133005: Removes unnecessary views::Widget::InitParams::top_level (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/chrome_views_delegate_aura.cc

diff --git a/chrome/browser/ui/views/chrome_views_delegate_aura.cc b/chrome/browser/ui/views/chrome_views_delegate_aura.cc

index c9d70811ba6c6dfbb3b3ce07d22b7cd97f9a95f9..0fee65ea6a306596a9c75501e2e01f803f9a0978 100644

--- a/chrome/browser/ui/views/chrome_views_delegate_aura.cc

+++ b/chrome/browser/ui/views/chrome_views_delegate_aura.cc

@@ -16,7 +16,7 @@ ChromeViewsDelegate::GetOpacityForInitParams(

#endif

// We want translucent windows when either we are in ASH or we are

// a top level window which is not of type TYPE_WINDOW.

- if (params.top_level && params.type != views::Widget::InitParams::TYPE_WINDOW)

+ if (!params.child && params.type != views::Widget::InitParams::TYPE_WINDOW)

return views::Widget::InitParams::TRANSLUCENT_WINDOW;

return views::Widget::InitParams::OPAQUE_WINDOW;