Use std::begin() and std::end() in base::ContainsValue()

Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to either arrays or containers
lacking a begin method (by overriding std::begin()).

Review-Url: https://codereview.chromium.org/2821313002
Cr-Commit-Position: refs/heads/master@{#466071}
Committed: https://chromium.googlesource.com/chromium/src/+/1bc3466095f183745f2fc934b266869689fba7d5

[Tom Sepez, 2017-04-18 16:30:00]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[Tom Sepez, 2017-04-18 16:30:22]

Description was changed from

==========
Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to ordinary C-style
arrays rather than just STL containers.
==========

to

==========
Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to ordinary C-style
arrays rather than just STL containers.
==========

[Tom Sepez, 2017-04-18 16:30:22]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[commit-bot: I haz the power, 2017-04-18 16:30:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-04-18 16:31:10]

Lei, for review.

[commit-bot: I haz the power, 2017-04-18 18:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:24:04]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-18 19:19:34]

So starring at this today, it occurred to me stl_util.h is for working with STL
containers. Making it work with C-style arrays is a bit of a stretch.

[Tom Sepez, 2017-04-18 19:24:49]

Description was changed from

==========
Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to ordinary C-style
arrays rather than just STL containers.
==========

to

==========
Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to either arrays or containers
lacking a begin method (by overriding std::begin()).
==========

[Tom Sepez, 2017-04-18 19:25:19]

On 2017/04/18 19:19:34, Lei Zhang wrote:
> So starring at this today, it occurred to me stl_util.h is for working with
STL
> containers. Making it work with C-style arrays is a bit of a stretch.

Updated description, still strechy?

[Lei Zhang, 2017-04-18 19:30:28]

thestig@chromium.org changed reviewers:
+ danakj@chromium.org

[Lei Zhang, 2017-04-18 19:30:28]

Let's ask danakj@ for a second opinion. I'm on the fence.

[Tom Sepez, 2017-04-20 16:29:34]

On 2017/04/18 19:30:28, Lei Zhang wrote:
> Let's ask danakj@ for a second opinion. I'm on the fence.

ping?

[danakj, 2017-04-20 16:36:24]

I think standard library algorithm things should work on arrays also, LGTM

[Tom Sepez, 2017-04-20 16:38:55]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:39:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 18:11:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492706335185380, "parent_rev":
"6a9bad439119e265a1846f21124125f6fdf97b4c", "commit_rev":
"1bc3466095f183745f2fc934b266869689fba7d5"}

[commit-bot: I haz the power, 2017-04-20 18:12:03]

Description was changed from

==========
Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to either arrays or containers
lacking a begin method (by overriding std::begin()).
==========

to

==========
Use std::begin() and std::end() in base::ContainsValue()

This allows ContainsValue() to be applied to either arrays or containers
lacking a begin method (by overriding std::begin()).

Review-Url: https://codereview.chromium.org/2821313002
Cr-Commit-Position: refs/heads/master@{#466071}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bc3466095f183745f2fc934b266...
==========

[commit-bot: I haz the power, 2017-04-20 18:12:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bc3466095f183745f2fc934b266...