[selectors4] Use common ancestor strategy for :focus-within

third_party/WebKit/Source/core/page/FocusController.cpp

Index: third_party/WebKit/Source/core/page/FocusController.cpp
diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp
index dcf0fbf94dfce46b854462bbdbbd8a16d6e0b1ff..f40302bec6edfd97b405e09ae6986ce9a28f6d2e 100644
--- a/third_party/WebKit/Source/core/page/FocusController.cpp
+++ b/third_party/WebKit/Source/core/page/FocusController.cpp
@@ -372,6 +372,7 @@ inline void DispatchEventsOnWindowAndFocusedElement(Document* document,
     Element* focused_element = document->FocusedElement();
     // Use focus_type kWebFocusTypePage, same as used in DispatchBlurEvent.
     focused_element->SetFocused(false, kWebFocusTypePage);
+    focused_element->SetHasFocusWithinUpToAncestor(false);

[rune, 2017/04/21 08:08:35]

I'm generally not so fond of default arguments and would prefer an explicit null
ancestor. Reading this code, I wonder which ancestor is that method referring
to?

[Manuel Rego, 2017/04/24 15:24:46]

Ok, I've made it mandatory.

     DispatchBlurEvent(*document, *focused_element);
   }
 
@@ -382,6 +383,7 @@ inline void DispatchEventsOnWindowAndFocusedElement(Document* document,
     Element* focused_element(document->FocusedElement());
     // Use focus_type kWebFocusTypePage, same as used in DispatchFocusEvent.
     focused_element->SetFocused(true, kWebFocusTypePage);
+    focused_element->SetHasFocusWithinUpToAncestor(true);
     DispatchFocusEvent(*document, *focused_element);
   }
 }