[selectors4] Use common ancestor strategy for :focus-within

third_party/WebKit/Source/core/page/FocusController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 354 matching lines @@
   // https://bugs.webkit.org/show_bug.cgi?id=33962
   if (Page* page = document->GetPage()) {
     if (page->Suspended())
       return;
   }
 
   if (!focused && document->FocusedElement()) {
     Element* focused_element = document->FocusedElement();
     // Use focus_type kWebFocusTypePage, same as used in DispatchBlurEvent.
     focused_element->SetFocused(false, kWebFocusTypePage);
+    focused_element->SetHasFocusWithinUpToAncestor(false);

[rune, 2017/04/21 08:08:35]

I'm generally not so fond of default arguments and would prefer an explicit null
ancestor. Reading this code, I wonder which ancestor is that method referring
to?

[Manuel Rego, 2017/04/24 15:24:46]

Ok, I've made it mandatory.

     DispatchBlurEvent(*document, *focused_element);
   }
 
   if (LocalDOMWindow* window = document->domWindow())
     window->DispatchEvent(
         Event::Create(focused ? EventTypeNames::focus : EventTypeNames::blur));
   if (focused && document->FocusedElement()) {
     Element* focused_element(document->FocusedElement());
     // Use focus_type kWebFocusTypePage, same as used in DispatchFocusEvent.
     focused_element->SetFocused(true, kWebFocusTypePage);
+    focused_element->SetHasFocusWithinUpToAncestor(true);
     DispatchFocusEvent(*document, *focused_element);
   }
 }
 
 inline bool HasCustomFocusLogic(const Element& element) {
   return element.IsHTMLElement() &&
          ToHTMLElement(element).HasCustomFocusLogic();
 }
 
 inline bool IsShadowHostWithoutCustomFocusLogic(const Element& element) {
@@ skipping 1001 matching lines @@
     it->FocusedFrameChanged();
 }
 
 DEFINE_TRACE(FocusController) {
   visitor->Trace(page_);
   visitor->Trace(focused_frame_);
   visitor->Trace(focus_changed_observers_);
 }
 
 }  // namespace blink