Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2821303002: Minor code cleanup, remove unused function isDaydreamVrIntent (Closed)

Created:
3 years, 8 months ago by bshe
Modified:
3 years, 8 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor code cleanup, remove unused function isDaydreamVrIntent Also static strings that are no longer used. BUG=None Review-Url: https://codereview.chromium.org/2821303002 Cr-Commit-Position: refs/heads/master@{#465259} Committed: https://chromium.googlesource.com/chromium/src/+/7f42efb4b50d37135d0224e5fe08e5ea9b5881bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bshe
Hi Micheal. Can you please take a look?
3 years, 8 months ago (2017-04-18 15:41:20 UTC) #4
mthiesse
lgtm
3 years, 8 months ago (2017-04-18 15:51:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821303002/1
3 years, 8 months ago (2017-04-18 16:23:08 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 16:28:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f42efb4b50d37135d0224e5fe08...

Powered by Google App Engine
This is Rietveld 408576698