Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2821273004: [ARM] Save all single precision float registers in the deoptimizer. (Closed)

Created:
3 years, 8 months ago by bbudge
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Save all single precision float registers in the deoptimizer. - All ARM hardware has 32 single precision float registers; save all s-registers regardless of the number of d-registers (16 or 32). LOG=N BUG=v8:6077 Review-Url: https://codereview.chromium.org/2821273004 Cr-Commit-Position: refs/heads/master@{#44810} Committed: https://chromium.googlesource.com/v8/v8/+/cb6331c0edb217a16e223909772a074b15348c22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bbudge
Not sure if you saw my comment on your CL to fix this bug. Don't ...
3 years, 8 months ago (2017-04-18 22:50:30 UTC) #6
bbudge
+Benedikt This has been bugging me for a while. PTAL
3 years, 8 months ago (2017-04-24 17:39:57 UTC) #8
Benedikt Meurer
Good catch! LGTM.
3 years, 8 months ago (2017-04-24 17:51:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821273004/1
3 years, 8 months ago (2017-04-24 18:05:59 UTC) #11
Jarin
lgtm. Thanks for fixing this!
3 years, 8 months ago (2017-04-24 18:18:31 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:26:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cb6331c0edb217a16e223909772a074b153...

Powered by Google App Engine
This is Rietveld 408576698