Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 2821273003: Rename ui-show-layer-borders to be consistent with other flag. (Closed)

Created:
3 years, 8 months ago by wutao
Modified:
3 years, 8 months ago
Reviewers:
reveman, Steven Holte
CC:
asvitkine+watch_chromium.org, cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ui-show-layer-borders to be consistent with other flag. Rename ui-show-layer-borders to ui-show-composited-layer-borders to be consistent with the renderer compositor flag. BUG=708518 TEST=AboutFlagsHistogramTest.CheckHistograms and Manual CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2821273003 Cr-Commit-Position: refs/heads/master@{#465450} Committed: https://chromium.googlesource.com/chromium/src/+/c63400e394a50c8b42ef798eaee47245c5febf04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/base/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
wutao
Hi reveman@, Please have a look of the rename. Hi holte@, Please review tools/metrics/histograms/histograms.xml. Thanks, ...
3 years, 8 months ago (2017-04-18 19:13:05 UTC) #3
reveman
lgtm
3 years, 8 months ago (2017-04-18 19:14:22 UTC) #4
Steven Holte
lgtm
3 years, 8 months ago (2017-04-18 22:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821273003/1
3 years, 8 months ago (2017-04-19 00:43:48 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 00:50:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c63400e394a50c8b42ef798eaee4...

Powered by Google App Engine
This is Rietveld 408576698