Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2821273002: [turbofan] Inline Array constructor calls with multiple parameters. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline Array constructor calls with multiple parameters. BUG=v8:6262 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2821273002 Cr-Commit-Position: refs/heads/master@{#44688} Committed: https://chromium.googlesource.com/v8/v8/+/245ab01ad46d0ac5cf307049a9ba5bd2b6b2f0a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -3 lines) Patch
M src/compiler/js-create-lowering.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 3 chunks +98 lines, -0 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-18 13:33:02 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the uncontroversial part of my Array constructor work. Will need to work ...
3 years, 8 months ago (2017-04-18 14:06:12 UTC) #6
Jarin
lgtm
3 years, 8 months ago (2017-04-18 14:11:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821273002/1
3 years, 8 months ago (2017-04-18 14:12:45 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 14:15:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/245ab01ad46d0ac5cf307049a9ba5bd2b6b...

Powered by Google App Engine
This is Rietveld 408576698