Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2821243003: Move MockScriptElementBase to a separate header file (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MockScriptElementBase to a separate header file https://codereview.chromium.org/2653923008/ will add a new file that uses MockScriptElementBase. BUG=694702 Review-Url: https://codereview.chromium.org/2821243003 Cr-Commit-Position: refs/heads/master@{#465452} Committed: https://chromium.googlesource.com/chromium/src/+/76259cd66b9138f4fc474b955ed035d0f27e7dd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -43 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/MockScriptElementBase.h View 1 chunk +53 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 2 chunks +1 line, -43 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
hiroshige
PTAL
3 years, 8 months ago (2017-04-19 00:40:35 UTC) #5
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-19 00:43:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821243003/1
3 years, 8 months ago (2017-04-19 01:03:17 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 01:09:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76259cd66b9138f4fc474b955ed0...

Powered by Google App Engine
This is Rietveld 408576698