Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2821243002: [dom] Fix flakiness of ParentNode-querySelector-All*.*. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[dom] Fix flakiness of ParentNode-querySelector-All*.*. :target doesn't work before the first page rendering in some browsers. This tries to fix it by running tests in an animation frame. BUG=711575 Review-Url: https://codereview.chromium.org/2821243002 Cr-Commit-Position: refs/heads/master@{#465182} Committed: https://chromium.googlesource.com/chromium/src/+/a377281d4100e91855312b96e98cea4c8fb34791

Patch Set 1 #

Patch Set 2 : rebaseline of ParentNode-querySelector-All-xht.xht #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/ParentNode-querySelector-All.html View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/ParentNode-querySelector-All-xht.xht View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/ParentNode-querySelector-All-xht-expected.txt View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
tkent
hayato@, would you review this please?
3 years, 8 months ago (2017-04-18 07:10:06 UTC) #4
hayato
lgtm
3 years, 8 months ago (2017-04-18 07:11:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821243002/20001
3 years, 8 months ago (2017-04-18 09:05:14 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 09:08:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a377281d4100e91855312b96e98c...

Powered by Google App Engine
This is Rietveld 408576698