Add UseCounter feature for requestMidiAccess with sysex:true

Add UseCounter feature for requestMidiAccess with sysex:true

There are some existing counters in the permissions layer regarding how the
prompts for midi sysex are resolved, a top-level counter like this makes it
easier to see the usage of this feature.

Review-Url: https://codereview.chromium.org/2821233002
Cr-Commit-Position: refs/heads/master@{#465190}
Committed: https://chromium.googlesource.com/chromium/src/+/c79c3710f38b28c4938e480efdb5541d84b593b8

[Timothy Loh, 2017-04-18 06:01:08]

Description was changed from

==========
Add UseCounter feature for requestMidiAccess with sysex:true
==========

to

==========
Add UseCounter feature for requestMidiAccess with sysex:true

There are some existing counters in the permissions layer regarding how the
prompts for midi sysex are resolved, a top-level counter like this makes it
easier to see the usage of this feature.
==========

[Timothy Loh, 2017-04-18 06:01:08]

timloh@chromium.org changed reviewers:
+ toyoshim@chromium.org

[Takashi Toyoshima, 2017-04-18 07:06:28]

lgtm with an optional comment

https://codereview.chromium.org/2821233002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp (right):

https://codereview.chromium.org/2821233002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp:83: if
(options.hasSysex() && options.sysex()) {
optional: I slightly prefer following names.
 - kRequestMIDIAccessWithSysExOption
 - kRequestMIDIAccessIframeWithSysExOption

[haraken, 2017-04-18 07:06:48]

histograms LGTM

[Timothy Loh, 2017-04-18 07:30:06]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2017-04-18 07:30:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/2821233002/#ps20001
(title: "rename as per comment")

[Timothy Loh, 2017-04-18 07:30:13]

https://codereview.chromium.org/2821233002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp (right):

https://codereview.chromium.org/2821233002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp:83: if
(options.hasSysex() && options.sysex()) {
On 2017/04/18 07:06:28, Takashi Toyoshima wrote:
> optional: I slightly prefer following names.
>  - kRequestMIDIAccessWithSysExOption
>  - kRequestMIDIAccessIframeWithSysExOption

Done.

[commit-bot: I haz the power, 2017-04-18 07:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 09:47:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492500606037220,
"parent_rev": "37ab82a26af3aa8755c1ab245240ce92e6b9896c", "commit_rev":
"c79c3710f38b28c4938e480efdb5541d84b593b8"}

[commit-bot: I haz the power, 2017-04-18 09:47:47]

Description was changed from

==========
Add UseCounter feature for requestMidiAccess with sysex:true

There are some existing counters in the permissions layer regarding how the
prompts for midi sysex are resolved, a top-level counter like this makes it
easier to see the usage of this feature.
==========

to

==========
Add UseCounter feature for requestMidiAccess with sysex:true

There are some existing counters in the permissions layer regarding how the
prompts for midi sysex are resolved, a top-level counter like this makes it
easier to see the usage of this feature.

Review-Url: https://codereview.chromium.org/2821233002
Cr-Commit-Position: refs/heads/master@{#465190}
Committed:
https://chromium.googlesource.com/chromium/src/+/c79c3710f38b28c4938e480efdb5...
==========

[commit-bot: I haz the power, 2017-04-18 09:47:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c79c3710f38b28c4938e480efdb5...