[keyed-store-generic] Update protectors if needed

[keyed-store-generic] Update protectors if needed

When adding or overwriting properties of an object, the generic
keyed store stub must check if that property's name might have
an associated protector (e.g. the ArraySpeciesProtector) and
take the slow path if so to ensure that the protector is updated
as needed.

BUG=v8:6269
Review-Url: https://codereview.chromium.org/2821213004
Cr-Commit-Position: refs/heads/master@{#44726}
Committed: https://chromium.googlesource.com/v8/v8/+/34a26e7dc4d31d1545bda5e5812d8116c1b36d22

[Jakob Kummerow, 2017-04-18 17:47:47]

jkummerow@chromium.org changed reviewers:
+ cbruni@chromium.org

[Jakob Kummerow, 2017-04-18 17:47:48]

Camillo: PTAL.

Dan: FYI.

[Jakob Kummerow, 2017-04-18 17:48:28]

Description was changed from

==========
[keyed-store-generic] Update protectors if needed

When adding properties to an object, the generic keyed store stub
must check if that property's name might have an associated
protector (e.g. the ArraySpeciesProtector) and take the slow path
if so to ensure that the protector is updated as needed.

BUG=v8:6269
==========

to

==========
[keyed-store-generic] Update protectors if needed

When adding or overwriting properties of an object, the generic
keyed store stub must check if that property's name might have
an associated protector (e.g. the ArraySpeciesProtector) and
take the slow path if so to ensure that the protector is updated
as needed.

BUG=v8:6269
==========

[Jakob Kummerow, 2017-04-18 17:51:28]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 17:51:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:18:05]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-04-19 09:06:33]

LGTM with nit

https://codereview.chromium.org/2821213004/diff/1/test/mjsunit/keyed-store-ge...
File test/mjsunit/keyed-store-generic.js (right):

https://codereview.chromium.org/2821213004/diff/1/test/mjsunit/keyed-store-ge...
test/mjsunit/keyed-store-generic.js:18: function MyArray() {}
assertTrue(%SpeciesProtector());

[Jakob Kummerow, 2017-04-19 13:11:46]

Thanks, landing.

https://codereview.chromium.org/2821213004/diff/1/test/mjsunit/keyed-store-ge...
File test/mjsunit/keyed-store-generic.js (right):

https://codereview.chromium.org/2821213004/diff/1/test/mjsunit/keyed-store-ge...
test/mjsunit/keyed-store-generic.js:18: function MyArray() {}
On 2017/04/19 09:06:32, Camillo Bruni wrote:
> assertTrue(%SpeciesProtector());

Done.

[Jakob Kummerow, 2017-04-19 13:11:50]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-04-19 13:11:50]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2821213004/#ps20001
(title: "fix nit")

[commit-bot: I haz the power, 2017-04-19 13:11:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 13:30:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 13:30:04]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Jakob Kummerow, 2017-04-19 13:49:28]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-04-19 13:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2821213004/#ps40001
(title: "--no-stress-opt")

[commit-bot: I haz the power, 2017-04-19 13:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 14:15:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492609768718530,
"parent_rev": "0e97280f2432ddb2171f914238b1bd09b9082691", "commit_rev":
"34a26e7dc4d31d1545bda5e5812d8116c1b36d22"}

[commit-bot: I haz the power, 2017-04-19 14:15:40]

Description was changed from

==========
[keyed-store-generic] Update protectors if needed

When adding or overwriting properties of an object, the generic
keyed store stub must check if that property's name might have
an associated protector (e.g. the ArraySpeciesProtector) and
take the slow path if so to ensure that the protector is updated
as needed.

BUG=v8:6269
==========

to

==========
[keyed-store-generic] Update protectors if needed

When adding or overwriting properties of an object, the generic
keyed store stub must check if that property's name might have
an associated protector (e.g. the ArraySpeciesProtector) and
take the slow path if so to ensure that the protector is updated
as needed.

BUG=v8:6269

Review-Url: https://codereview.chromium.org/2821213004
Cr-Commit-Position: refs/heads/master@{#44726}
Committed:
https://chromium.googlesource.com/v8/v8/+/34a26e7dc4d31d1545bda5e5812d8116c1b...
==========

[commit-bot: I haz the power, 2017-04-19 14:15:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/34a26e7dc4d31d1545bda5e5812d8116c1b...