cros: Adds ShellPort functions for simplified display mode

cros: Adds ShellPort functions for simplified display mode

Specifically AshWindowTreeHost::Create() now calls to the ShellPort
with additional information that mus needs. Additionally added
CreateNativeDisplayDelegate(), which is not yet wired
up. CreateNativeDisplayDelegate() will be wired up separately.

BUG=708287
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2821203002
Cr-Commit-Position: refs/heads/master@{#465255}
Committed: https://chromium.googlesource.com/chromium/src/+/8f92a696b9f562141c5ea6af2e5dd1628a6694d8

[James Cook, 2017-04-18 00:43:39]

https://codereview.chromium.org/2821203002/diff/20001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host.h (right):

https://codereview.chromium.org/2821203002/diff/20001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host.h:37: static AshWindowTreeHost* Create(
It would be nice if this returned unique_ptr<>, even if the caller immediately
release()'d it.

https://codereview.chromium.org/2821203002/diff/20001/ash/shell_port.h
File ash/shell_port.h (right):

https://codereview.chromium.org/2821203002/diff/20001/ash/shell_port.h#newcod...
ash/shell_port.h:212: virtual AshWindowTreeHost* CreateAshWindowTreeHost(
I think this would be better if it returned unique_ptr<>, even if the caller to
AshWindowTreeHost::Create() had to release() it.

[sky, 2017-04-18 02:55:10]

Updated, take another look?

https://codereview.chromium.org/2821203002/diff/20001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host.h (right):

https://codereview.chromium.org/2821203002/diff/20001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host.h:37: static AshWindowTreeHost* Create(
On 2017/04/18 00:43:39, James Cook wrote:
> It would be nice if this returned unique_ptr<>, even if the caller immediately
> release()'d it.

I actually had that in an earlier patch, but convinced myself ownership should
happen via the RootWindowController. But that doesn't matter here, so back to
making this return a unique_ptr.

[sky, 2017-04-18 02:55:36]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 02:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 03:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 03:26:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-04-18 15:02:42]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 15:03:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-04-18 15:12:05]

LGTM

[commit-bot: I haz the power, 2017-04-18 15:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 15:24:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-04-18 15:27:18]

The CQ bit was checked by sky@chromium.org

[sky, 2017-04-18 15:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2821203002/#ps80001
(title: "Fix x11 build")

[commit-bot: I haz the power, 2017-04-18 15:27:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 16:09:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492529238760070,
"parent_rev": "8d8bfb5cfe5927029925c7f95c98414326c8cb45", "commit_rev":
"8f92a696b9f562141c5ea6af2e5dd1628a6694d8"}

[commit-bot: I haz the power, 2017-04-18 16:09:50]

Description was changed from

==========
cros: Adds ShellPort functions for simplified display mode

Specifically AshWindowTreeHost::Create() now calls to the ShellPort
with additional information that mus needs. Additionally added
CreateNativeDisplayDelegate(), which is not yet wired
up. CreateNativeDisplayDelegate() will be wired up separately.

BUG=708287
TEST=none
R=jamescook@chromium.org
==========

to

==========
cros: Adds ShellPort functions for simplified display mode

Specifically AshWindowTreeHost::Create() now calls to the ShellPort
with additional information that mus needs. Additionally added
CreateNativeDisplayDelegate(), which is not yet wired
up. CreateNativeDisplayDelegate() will be wired up separately.

BUG=708287
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2821203002
Cr-Commit-Position: refs/heads/master@{#465255}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f92a696b9f562141c5ea6af2e5d...
==========

[commit-bot: I haz the power, 2017-04-18 16:09:51]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8f92a696b9f562141c5ea6af2e5d...