Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2821193005: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/safe_browsing (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/safe_browsing This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 Review-Url: https://codereview.chromium.org/2821193005 Cr-Commit-Position: refs/heads/master@{#465836} Committed: https://chromium.googlesource.com/chromium/src/+/b5f84b81f9035634e0fba8463a6337924f7923d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -269 lines) Patch
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_model_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_feedback.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_feedback_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 9 chunks +36 lines, -45 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 16 chunks +34 lines, -29 lines 0 comments Download
M chrome/browser/safe_browsing/mock_permission_report_sender.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/notification_image_reporter.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/notification_image_reporter_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/permission_reporter_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 9 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/threat_details.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details_history.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tzik
PTAL
3 years, 8 months ago (2017-04-19 13:27:05 UTC) #6
mattm
lgtm
3 years, 8 months ago (2017-04-19 19:40:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821193005/1
3 years, 8 months ago (2017-04-20 00:47:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 00:55:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5f84b81f9035634e0fba8463a63...

Powered by Google App Engine
This is Rietveld 408576698