Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

Issue 2821163002: Clean up DownloadAttribution Finch experiments (Closed)
Patch Set: nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
index d07af76d67d6559c88a3269dea52b3cd2fdde7c5..3742cf1a6bfc0f71246bc23ba4a9e919b8b7bfa7 100644
--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h
@@ -13,8 +13,6 @@
#include "third_party/protobuf/src/google/protobuf/repeated_field.h"
#include "url/gurl.h"
-class Profile;
-
namespace safe_browsing {
class SafeBrowsingNavigationObserver;
@@ -95,8 +93,6 @@ struct NavigationEventList {
class SafeBrowsingNavigationObserverManager
: public base::RefCountedThreadSafe<SafeBrowsingNavigationObserverManager> {
public:
- static const base::Feature kDownloadAttribution;
-
// For UMA histogram counting. Do NOT change order.
enum AttributionResult {
SUCCESS = 1, // Identified referrer chain is not empty.
@@ -120,9 +116,9 @@ class SafeBrowsingNavigationObserverManager
static GURL ClearEmptyRef(const GURL& url);
// Checks if we should enable observing navigations for safe browsing purpose.
- // Return true if the safe browsing service and the |kDownloadAttribution|
- // feature are both enabled, and safe browsing service is initialized.
- static bool IsEnabledAndReady(Profile* profile);
+ // Return true if the safe browsing safe browsing service is enabled and
+ // initialized.
+ static bool IsEnabledAndReady(content::WebContents* web_contents);
SafeBrowsingNavigationObserverManager();

Powered by Google App Engine
This is Rietveld 408576698