chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc - Issue 2821163002: Clean up DownloadAttribution Finch experiments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

Issue 2821163002: Clean up DownloadAttribution Finch experiments (Closed)

Patch Set: nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc ('k') | chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h » ('j') | chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

index daab3f73e34f5ceab6d6d61796b82fccec502cd1..a7e0881b9ec85d6323191f4a0f3ba99bbf6ff022 100644

--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

@@ -163,7 +163,9 @@ class SBNavigationObserverBrowserTest : public InProcessBrowserTest {

SBNavigationObserverBrowserTest() {}

void SetUpOnMainThread() override {

- // Disable Safe Browsing service since it is irrelevant to this test.

+ // Disable Safe Browsing service so we can directly control when

+ // SafeBrowsingNavigationObserverManager and SafeBrowsingNavigationObserver

+ // are instantiated.

browser()->profile()->GetPrefs()->SetBoolean(prefs::kSafeBrowsingEnabled,

false);

ASSERT_TRUE(embedded_test_server()->Start());