Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2821133005: md-settings: Fix fingerprint list tests. (Closed)

Created:
3 years, 8 months ago by sammiequon
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

md-settings: Fix fingerprint list tests. Settings fingerprint list tests do not wait for the method to be called before procedding if the method has been called previously. Fix this by resetting the promise resolver each time the method is called, if it is called again later in the test. TEST=browser_tests --gtest_filter="CrSettingsFingerprintListTest.*" BUG=712880 Review-Url: https://codereview.chromium.org/2821133005 Cr-Commit-Position: refs/heads/master@{#465639} Committed: https://chromium.googlesource.com/chromium/src/+/786ed37e758793e92b323bcad36fad924ca305ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/test/data/webui/settings/fingerprint_browsertest_chromeos.js View 4 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
sammiequon
stevenjb@, xiaoyinh@ - Please take a look. Thanks!
3 years, 8 months ago (2017-04-18 23:08:03 UTC) #3
stevenjb
lgtm
3 years, 8 months ago (2017-04-18 23:23:02 UTC) #6
sammiequon
On 2017/04/18 23:23:02, stevenjb wrote: > lgtm Thanks!
3 years, 8 months ago (2017-04-18 23:25:01 UTC) #7
xiaoyinh(OOO Sep 11-29)
lgtm.
3 years, 8 months ago (2017-04-18 23:54:18 UTC) #8
sammiequon
On 2017/04/18 23:54:18, xiaoyinh wrote: > lgtm. Thanks!
3 years, 8 months ago (2017-04-19 16:50:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821133005/1
3 years, 8 months ago (2017-04-19 16:51:47 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:57:16 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/786ed37e758793e92b323bcad36f...

Powered by Google App Engine
This is Rietveld 408576698