Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2821133002: Disable the direct-drawing optimization for quads with opacity (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the direct-drawing optimization for quads with opacity. R=enne@chromium.org BUG=709081 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2821133002 Cr-Commit-Position: refs/heads/master@{#465078} Committed: https://chromium.googlesource.com/chromium/src/+/ada0f67fca5c772aac731925e3ce4918548a04a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M cc/output/gl_renderer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/opacity-with-mask.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/opacity-with-mask-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/compositing/opacity-with-mask-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Stephen Chennney
Verified it fixes it. But enne@ or some other cc owner will need to approve. ...
3 years, 8 months ago (2017-04-17 19:18:40 UTC) #6
enne (OOO)
lgtm to land for the branch, but this should really be a cc pixel test.
3 years, 8 months ago (2017-04-17 19:51:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821133002/1
3 years, 8 months ago (2017-04-17 20:03:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 00:35:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ada0f67fca5c772aac731925e3ce...

Powered by Google App Engine
This is Rietveld 408576698