Issue 282113002: Fix installer download for apps v2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282113002: Fix installer download for apps v2. (Closed)

Created:
6 years, 7 months ago by Jamie

Modified:
6 years, 7 months ago

Reviewers:
garykac, kelvinp

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix installer download for apps v2. This is a poor-man's solution to unblock the apps v2 release. It causes an existing Chrome window (or a new one if there aren't any) to download the installer. This is needed because the v2 app doesn't have a brower context, which means no download shelf for the user to click when the download completes. The UX is pretty horrible because the Chrome window pops on top of the app window, typically obscuring the instructions. I'm open to better solutions. This also fixes a bug in the host setup and install dialogs, which were not showing the translucent screen that normally obscures the main UI while a modal dialog is open. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270802

Patch Set 1 #

Patch Set 2 : Removed ignored parameters. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	remoting/webapp/host_install_dialog.js	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
	M	remoting/webapp/html/template_main.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/282113002/20001

6 years, 7 months ago (2014-05-15 17:13:41 UTC) #4

Message was sent while issue was closed.

Change committed as 270802

Expand Messages | Collapse Messages