Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: remoting/webapp/host_install_dialog.js

Issue 282113002: Fix installer download for apps v2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed ignored parameters. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/html/template_main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/host_install_dialog.js
diff --git a/remoting/webapp/host_install_dialog.js b/remoting/webapp/host_install_dialog.js
index f94cca6a5869df50962cc87b894a9bed82172ec2..71bf84dc30c6908f11ee564c1c1953eb0d86ef79 100644
--- a/remoting/webapp/host_install_dialog.js
+++ b/remoting/webapp/host_install_dialog.js
@@ -83,7 +83,13 @@ remoting.HostInstallDialog.prototype.show = function(
}
// Start downloading the package.
- window.location = hostPackageUrl;
+ if (remoting.isAppsV2) {
+ // TODO(jamiewalch): Use chrome.downloads when it is available to
+ // apps v2 (http://crbug.com/174046)
+ window.open(hostPackageUrl);
+ } else {
+ window.location = hostPackageUrl;
+ }
/** @type {function(remoting.HostController.AsyncResult):void} */
this.onDoneHandler_ = onDone;
@@ -134,4 +140,3 @@ remoting.HostInstallDialog.prototype.onRetryClicked_ = function() {
'click', this.onCancelClickedHandler_, false);
remoting.setMode(remoting.AppMode.HOST_INSTALL_PROMPT);
};
-
« no previous file with comments | « no previous file | remoting/webapp/html/template_main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698