Remove URLRequestJob::GetResponseCode implementations from chrome/

Remove URLRequestJob::GetResponseCode implementations from chrome/

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
Review-Url: https://codereview.chromium.org/2821093002
Cr-Commit-Position: refs/heads/master@{#465587}
Committed: https://chromium.googlesource.com/chromium/src/+/db0751b8db4b09ffba0d7907dcb93311b2c596ec

[mmenke, 2017-04-17 18:16:59]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 18:17:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-04-17 18:52:11]

mmenke@chromium.org changed reviewers:
+ felt@chromium.org, nparker@chromium.org, pasko@chromium.org

[mmenke, 2017-04-17 18:52:11]

[pasko]:  Please review c/b/predirectors.
[nparker]:  Please review c/b/safe_browsing.
[felt]:  Please review c/b/ssl.

Per description, this just removes a redundant method, which subclasses could
use to return inconsistent data.

[commit-bot: I haz the power, 2017-04-17 19:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:07:28]

Dry run: This issue passed the CQ dry run.

[Nathan Parker, 2017-04-17 20:31:00]

LGTM for safe_browsing/*

[felt, 2017-04-17 21:00:19]

c/b/ssl lgtm

[pasko, 2017-04-19 13:16:44]

chrome/browser/predictors lgtm, sorry for delay

[pasko, 2017-04-19 13:16:50]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2017-04-19 13:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-04-19 13:48:24]

On 2017/04/19 13:16:44, pasko wrote:
> chrome/browser/predictors lgtm, sorry for delay

Not a problem, I'm not in any rush.

Thanks everyone!

[commit-bot: I haz the power, 2017-04-19 14:07:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492607810600150, "parent_rev":
"2cc05d188ea62c172bf3bf54611671c95c380ab7", "commit_rev":
"db0751b8db4b09ffba0d7907dcb93311b2c596ec"}

[commit-bot: I haz the power, 2017-04-19 14:07:47]

Description was changed from

==========
Remove URLRequestJob::GetResponseCode implementations from chrome/

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
==========

to

==========
Remove URLRequestJob::GetResponseCode implementations from chrome/

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481

Review-Url: https://codereview.chromium.org/2821093002
Cr-Commit-Position: refs/heads/master@{#465587}
Committed:
https://chromium.googlesource.com/chromium/src/+/db0751b8db4b09ffba0d7907dcb9...
==========

[commit-bot: I haz the power, 2017-04-19 14:07:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db0751b8db4b09ffba0d7907dcb9...