Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2821073002: Do not parse caption-side: left / right as valid CSS. (Closed)

Created:
3 years, 8 months ago by emilio
Modified:
3 years, 8 months ago
Reviewers:
nainar, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not parse caption-side: left / right as valid CSS. We don't support it, and it's confusing to claim we do. BUG=710734 Review-Url: https://codereview.chromium.org/2821073002 Cr-Commit-Position: refs/heads/master@{#465173} Committed: https://chromium.googlesource.com/chromium/src/+/4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe

Patch Set 1 #

Patch Set 2 : Do not parse caption-side: left / right as valid CSS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
emilio
Hi, could you take a look at this? Thanks in advance!
3 years, 8 months ago (2017-04-18 00:46:06 UTC) #10
esprehn
https://developer.mozilla.org/en-US/docs/Web/CSS/caption-side claims this feature was dropped from the spec? lgtm
3 years, 8 months ago (2017-04-18 02:01:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821073002/20001
3 years, 8 months ago (2017-04-18 07:34:36 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 07:39:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4af5b86049ac7e3b8fb3db9b5cb9...

Powered by Google App Engine
This is Rietveld 408576698