Convert bookmarks NTP panel to UIViewController.

Convert bookmarks NTP panel to UIViewController.

Followup to codereview.chromium.org/2806153004, also convert the bookmarks
panel.

BUG=708319
Review-Url: https://codereview.chromium.org/2821063002
Cr-Commit-Position: refs/heads/master@{#465086}
Committed: https://chromium.googlesource.com/chromium/src/+/892f16d9e2e43c6d3e410b1cf974391fbe26998a

[justincohen, 2017-04-17 16:00:28]

justincohen@chromium.org changed reviewers:
+ noyau@chromium.org, rohitrao@chromium.org

[justincohen, 2017-04-17 16:00:29]

PTAL.

CC: noyau@ for discussion around bookmarks

[rohitrao (ping after 24h), 2017-04-17 16:11:30]

lgtm

https://codereview.chromium.org/2821063002/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
(right):

https://codereview.chromium.org/2821063002/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm:1187:
self.view = [[ContentView alloc] initWithFrame:CGRectZero];
I believe that everything except for this line should go into viewDidLoad.

[justincohen, 2017-04-17 16:18:57]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[justincohen, 2017-04-17 16:19:06]

https://codereview.chromium.org/2821063002/diff/1/ios/chrome/browser/ui/bookm...
File ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm
(right):

https://codereview.chromium.org/2821063002/diff/1/ios/chrome/browser/ui/bookm...
ios/chrome/browser/ui/bookmarks/bookmark_home_tablet_ntp_controller.mm:1187:
self.view = [[ContentView alloc] initWithFrame:CGRectZero];
On 2017/04/17 16:11:30, rohitrao wrote:
> I believe that everything except for this line should go into viewDidLoad.

Done.

[commit-bot: I haz the power, 2017-04-17 16:19:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[justincohen, 2017-04-17 16:20:33]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 16:20:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 16:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 16:29:06]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[justincohen, 2017-04-18 00:35:03]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 00:35:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:55:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 00:55:54]

Dry run: This issue passed the CQ dry run.

[justincohen, 2017-04-18 00:56:31]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2017-04-18 00:56:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2821063002/#ps60001
(title: "Fix unit tests")

[commit-bot: I haz the power, 2017-04-18 00:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 01:00:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492476991683270,
"parent_rev": "147bd1eedea8ce66f162faa43535d60137817d91", "commit_rev":
"892f16d9e2e43c6d3e410b1cf974391fbe26998a"}

[commit-bot: I haz the power, 2017-04-18 01:01:54]

Description was changed from

==========
Convert bookmarks NTP panel to UIViewController.

Followup to codereview.chromium.org/2806153004, also convert the bookmarks
panel.

BUG=708319
==========

to

==========
Convert bookmarks NTP panel to UIViewController.

Followup to codereview.chromium.org/2806153004, also convert the bookmarks
panel.

BUG=708319

Review-Url: https://codereview.chromium.org/2821063002
Cr-Commit-Position: refs/heads/master@{#465086}
Committed:
https://chromium.googlesource.com/chromium/src/+/892f16d9e2e43c6d3e410b1cf974...
==========

[commit-bot: I haz the power, 2017-04-18 01:01:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/892f16d9e2e43c6d3e410b1cf974...