Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2821053004: Revert of Remove the code to store and load QUIC server configs in the disk cache. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/network_session_configurator/network_session_configurator.h " 5 #include "components/network_session_configurator/network_session_configurator.h "
6 6
7 #include <map> 7 #include <map>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) { 63 TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
64 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled"); 64 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
65 65
66 ParseFieldTrials(); 66 ParseFieldTrials();
67 67
68 EXPECT_TRUE(params_.enable_quic); 68 EXPECT_TRUE(params_.enable_quic);
69 EXPECT_FALSE(params_.mark_quic_broken_when_network_blackholes); 69 EXPECT_FALSE(params_.mark_quic_broken_when_network_blackholes);
70 EXPECT_FALSE(params_.retry_without_alt_svc_on_quic_errors); 70 EXPECT_FALSE(params_.retry_without_alt_svc_on_quic_errors);
71 EXPECT_EQ(1350u, params_.quic_max_packet_length); 71 EXPECT_EQ(1350u, params_.quic_max_packet_length);
72 EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options); 72 EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
73 EXPECT_EQ(0.25f, params_.quic_load_server_info_timeout_srtt_multiplier);
74 EXPECT_FALSE(params_.quic_enable_connection_racing);
73 EXPECT_FALSE(params_.enable_server_push_cancellation); 75 EXPECT_FALSE(params_.enable_server_push_cancellation);
74 EXPECT_FALSE(params_.quic_enable_non_blocking_io); 76 EXPECT_FALSE(params_.quic_enable_non_blocking_io);
77 EXPECT_FALSE(params_.quic_disable_disk_cache);
75 EXPECT_FALSE(params_.quic_close_sessions_on_ip_change); 78 EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
76 EXPECT_EQ(net::kIdleConnectionTimeoutSeconds, 79 EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
77 params_.quic_idle_connection_timeout_seconds); 80 params_.quic_idle_connection_timeout_seconds);
78 EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds); 81 EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
79 EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds, 82 EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds,
80 params_.quic_packet_reader_yield_after_duration_milliseconds); 83 params_.quic_packet_reader_yield_after_duration_milliseconds);
81 EXPECT_FALSE(params_.quic_race_cert_verification); 84 EXPECT_FALSE(params_.quic_race_cert_verification);
82 EXPECT_FALSE(params_.quic_do_not_fragment); 85 EXPECT_FALSE(params_.quic_do_not_fragment);
83 EXPECT_FALSE(params_.quic_estimate_initial_rtt); 86 EXPECT_FALSE(params_.quic_estimate_initial_rtt);
84 EXPECT_FALSE(params_.quic_migrate_sessions_on_network_change); 87 EXPECT_FALSE(params_.quic_migrate_sessions_on_network_change);
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 base::FieldTrialList::CreateFieldTrial("HTTP2", "Enabled"); 332 base::FieldTrialList::CreateFieldTrial("HTTP2", "Enabled");
330 333
331 ParseFieldTrials(); 334 ParseFieldTrials();
332 335
333 net::SettingsMap expected_settings; 336 net::SettingsMap expected_settings;
334 expected_settings[static_cast<net::SpdySettingsIds>(7)] = 1234; 337 expected_settings[static_cast<net::SpdySettingsIds>(7)] = 1234;
335 expected_settings[static_cast<net::SpdySettingsIds>(25)] = 5678; 338 expected_settings[static_cast<net::SpdySettingsIds>(25)] = 5678;
336 EXPECT_EQ(expected_settings, params_.http2_settings); 339 EXPECT_EQ(expected_settings, params_.http2_settings);
337 } 340 }
338 341
342 TEST_F(NetworkSessionConfiguratorTest,
343 QuicLoadServerInfoTimeToSmoothedRttFromFieldTrialParams) {
344 std::map<std::string, std::string> field_trial_params;
345 field_trial_params["load_server_info_time_to_srtt"] = "0.5";
346 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
347 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
348
349 ParseFieldTrials();
350
351 EXPECT_EQ(0.5f, params_.quic_load_server_info_timeout_srtt_multiplier);
352 }
353
354 TEST_F(NetworkSessionConfiguratorTest, QuicEnableConnectionRacing) {
355 std::map<std::string, std::string> field_trial_params;
356 field_trial_params["enable_connection_racing"] = "true";
357 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
358 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
359
360 ParseFieldTrials();
361
362 EXPECT_TRUE(params_.quic_enable_connection_racing);
363 }
364
339 TEST_F(NetworkSessionConfiguratorTest, QuicEnableNonBlockingIO) { 365 TEST_F(NetworkSessionConfiguratorTest, QuicEnableNonBlockingIO) {
340 std::map<std::string, std::string> field_trial_params; 366 std::map<std::string, std::string> field_trial_params;
341 field_trial_params["enable_non_blocking_io"] = "true"; 367 field_trial_params["enable_non_blocking_io"] = "true";
342 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params); 368 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
343 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled"); 369 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
344 370
345 ParseFieldTrials(); 371 ParseFieldTrials();
346 372
347 EXPECT_TRUE(params_.quic_enable_non_blocking_io); 373 EXPECT_TRUE(params_.quic_enable_non_blocking_io);
348 } 374 }
349 375
376 TEST_F(NetworkSessionConfiguratorTest, QuicDisableDiskCache) {
377 std::map<std::string, std::string> field_trial_params;
378 field_trial_params["disable_disk_cache"] = "true";
379 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
380 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
381
382 ParseFieldTrials();
383
384 EXPECT_TRUE(params_.quic_disable_disk_cache);
385 }
386
350 TEST_F(NetworkSessionConfiguratorTest, TCPFastOpenHttpsEnabled) { 387 TEST_F(NetworkSessionConfiguratorTest, TCPFastOpenHttpsEnabled) {
351 base::FieldTrialList::CreateFieldTrial("TCPFastOpen", "HttpsEnabled"); 388 base::FieldTrialList::CreateFieldTrial("TCPFastOpen", "HttpsEnabled");
352 389
353 ParseFieldTrials(); 390 ParseFieldTrials();
354 391
355 EXPECT_TRUE(params_.enable_tcp_fast_open_for_ssl); 392 EXPECT_TRUE(params_.enable_tcp_fast_open_for_ssl);
356 } 393 }
357 394
358 TEST_F(NetworkSessionConfiguratorTest, QuicForceHolBlocking) { 395 TEST_F(NetworkSessionConfiguratorTest, QuicForceHolBlocking) {
359 std::map<std::string, std::string> field_trial_params; 396 std::map<std::string, std::string> field_trial_params;
360 field_trial_params["force_hol_blocking"] = "true"; 397 field_trial_params["force_hol_blocking"] = "true";
361 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params); 398 variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
362 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled"); 399 base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
363 400
364 ParseFieldTrials(); 401 ParseFieldTrials();
365 402
366 EXPECT_TRUE(params_.quic_force_hol_blocking); 403 EXPECT_TRUE(params_.quic_force_hol_blocking);
367 } 404 }
368 405
369 } // namespace test 406 } // namespace test
OLDNEW
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698