Introduce base::IgnoreReuse() to wrap OnceCallback into RepeatingCallback

Introduce base::IgnoreReuse() to wrap OnceCallback into RepeatingCallback

This CL adds base::IgnoreReuse() and applies it to ImportantFileWriter.

In some rare case such as ImportantFileWriter, ServiceWorkerStorage, and
Mojo stuff, a called-only-once callback object is copied and passed to
separate code paths, that blocks OnceCallback migration.
base::IgnoreReuse() is a workaround for that by wrapping OnceCallback
into a RepeatingCallback, and ignores past-first calls.

BUG=668014
Review-Url: https://codereview.chromium.org/2820993002
Cr-Commit-Position: refs/heads/master@{#465979}
Committed: https://chromium.googlesource.com/chromium/src/+/faa3495a7a1032e994a62ddb6009b23f2ac5a33c

[tzik, 2017-04-17 07:12:13]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 07:12:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-17 07:54:03]

Description was changed from

==========
Introduce base::IgnoreReuse() to wrap OnceCallback into RepeatingCallback

BUG=
==========

to

==========
Introduce base::IgnoreReuse() to wrap OnceCallback into RepeatingCallback

This CL adds base::IgnoreReuse() and applies it to ImportantFileWriter.

In some rare case such as ImportantFileWriter, ServiceWorkerStorage, and
Mojo stuff, a called-only-once callback object is copied and passed to
separate code paths, that blocks OnceCallback migration.
base::IgnoreReuse() is a workaround for that by wrapping OnceCallback
into a RepeatingCallback, and ignores past-first calls.

BUG=668014
==========

[tzik, 2017-04-17 07:54:34]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-04-17 07:54:35]

PTAL

[commit-bot: I haz the power, 2017-04-17 08:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 08:33:14]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-04-18 06:45:39]

Code LGTM but I'm uncertain about the name. I don't want to block this CL on
naming issues... but maybe we could name it something like
AdaptCallbackForRepeating? I don't know =(

https://codereview.chromium.org/2820993002/diff/1/base/callback_helpers.h
File base/callback_helpers.h (right):

https://codereview.chromium.org/2820993002/diff/1/base/callback_helpers.h#new...
base/callback_helpers.h:49: if (!subtle::NoBarrier_AtomicExchange(&is_first_,
0))
Nit: maybe naming would be slightly clearer by calling this has_run_ (and
flipping the meaning of 1 and 0)

[tzik, 2017-04-20 05:19:43]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 05:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 05:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 05:32:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tzik, 2017-04-20 05:33:48]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 05:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-20 06:06:05]

https://codereview.chromium.org/2820993002/diff/1/base/callback_helpers.h
File base/callback_helpers.h (right):

https://codereview.chromium.org/2820993002/diff/1/base/callback_helpers.h#new...
base/callback_helpers.h:49: if (!subtle::NoBarrier_AtomicExchange(&is_first_,
0))
On 2017/04/18 06:45:39, dcheng (OOO through May 2) wrote:
> Nit: maybe naming would be slightly clearer by calling this has_run_ (and
> flipping the meaning of 1 and 0)

Done.

[tzik, 2017-04-20 06:15:50]

The CQ bit was unchecked by tzik@chromium.org

[tzik, 2017-04-20 06:20:33]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 06:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 07:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 07:39:19]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-20 12:15:41]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-04-20 12:15:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2820993002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2017-04-20 12:15:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 12:19:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492690541688130,
"parent_rev": "b51c609b0adcce8dbe4fe185e85a7014af5b79a2", "commit_rev":
"faa3495a7a1032e994a62ddb6009b23f2ac5a33c"}

[commit-bot: I haz the power, 2017-04-20 12:20:01]

Description was changed from

==========
Introduce base::IgnoreReuse() to wrap OnceCallback into RepeatingCallback

This CL adds base::IgnoreReuse() and applies it to ImportantFileWriter.

In some rare case such as ImportantFileWriter, ServiceWorkerStorage, and
Mojo stuff, a called-only-once callback object is copied and passed to
separate code paths, that blocks OnceCallback migration.
base::IgnoreReuse() is a workaround for that by wrapping OnceCallback
into a RepeatingCallback, and ignores past-first calls.

BUG=668014
==========

to

==========
Introduce base::IgnoreReuse() to wrap OnceCallback into RepeatingCallback

This CL adds base::IgnoreReuse() and applies it to ImportantFileWriter.

In some rare case such as ImportantFileWriter, ServiceWorkerStorage, and
Mojo stuff, a called-only-once callback object is copied and passed to
separate code paths, that blocks OnceCallback migration.
base::IgnoreReuse() is a workaround for that by wrapping OnceCallback
into a RepeatingCallback, and ignores past-first calls.

BUG=668014

Review-Url: https://codereview.chromium.org/2820993002
Cr-Commit-Position: refs/heads/master@{#465979}
Committed:
https://chromium.googlesource.com/chromium/src/+/faa3495a7a1032e994a62ddb6009...
==========

[commit-bot: I haz the power, 2017-04-20 12:20:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/faa3495a7a1032e994a62ddb6009...