Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2820983003: Revert of Replace requirePageReconstruction with setCustomUserAgent (Closed)

Created:
3 years, 8 months ago by rohitrao (ping after 24h)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org, sdefresne
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace requirePageReconstruction with setCustomUserAgent (patchset #5 id:100001 of https://codereview.chromium.org/2811073005/ ) Reason for revert: Seeing crashes in EG tests: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/26550 Original issue's description: > Replace requirePageReconstruction with setCustomUserAgent > > WKWebView provides a property: customUserAgent that we can use to > change the user agent associated with the web view, which means that we > don't have to requirePageConstruction anymore when user agent changes. > > After applying this change, I observed that it's becoming significantly > faster to navigate between desktop and mobile pages during back and > forward navigations. > > BUG=707368 > > Review-Url: https://codereview.chromium.org/2811073005 > Cr-Commit-Position: refs/heads/master@{#464830} > Committed: https://chromium.googlesource.com/chromium/src/+/b647f8362016d8e5b7a614e92b72331d070a32cf TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,liaoyuke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=707368 Review-Url: https://codereview.chromium.org/2820983003 Cr-Commit-Position: refs/heads/master@{#464917} Committed: https://chromium.googlesource.com/chromium/src/+/57f76e7371706d96c3cd0915f8efc04fab8c1166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 7 chunks +26 lines, -38 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util.h View 3 chunks +2 lines, -4 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util.mm View 3 chunks +9 lines, -5 lines 0 comments Download
M ios/web/web_view_creation_util.mm View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rohitrao (ping after 24h)
Created Revert of Replace requirePageReconstruction with setCustomUserAgent
3 years, 8 months ago (2017-04-17 12:43:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820983003/1
3 years, 8 months ago (2017-04-17 12:43:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/57f76e7371706d96c3cd0915f8efc04fab8c1166
3 years, 8 months ago (2017-04-17 12:55:02 UTC) #6
liaoyuke
3 years, 8 months ago (2017-04-17 19:52:07 UTC) #7
Message was sent while issue was closed.
On 2017/04/17 12:55:02, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/57f76e7371706d96c3cd0915f8ef...

lgtm.

Powered by Google App Engine
This is Rietveld 408576698