chrome/browser/extensions/updater/manifest_fetch_data.cc - Issue 282093012: Remove dependencies of Metrics{Service,Log} on g_browser_process->local_state()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/manifest_fetch_data.cc

Issue 282093012: Remove dependencies of Metrics{Service,Log} on g_browser_process->local_state() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove cruft Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader.cc ('k') | chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc » ('j') | chrome/browser/metrics/metrics_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/manifest_fetch_data.cc

diff --git a/chrome/browser/extensions/updater/manifest_fetch_data.cc b/chrome/browser/extensions/updater/manifest_fetch_data.cc

index 3144afc77708f799c588e9db698ec38decb630ce..9e5890a328cb09dd9e05818c5c866986b3010fd3 100644

--- a/chrome/browser/extensions/updater/manifest_fetch_data.cc

+++ b/chrome/browser/extensions/updater/manifest_fetch_data.cc

@@ -10,6 +10,7 @@

#include "base/metrics/histogram.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/google/google_util.h"

#include "chrome/browser/metrics/metrics_service.h"

#include "chrome/browser/omaha_query_params/omaha_query_params.h"

@@ -103,7 +104,8 @@ bool ManifestFetchData::AddExtension(const std::string& id,

if (ping_data->rollcall_days == kNeverPinged ||

ping_data->rollcall_days > 0) {

ping_value += "r=" + base::IntToString(ping_data->rollcall_days);

- if (MetricsServiceHelper::IsMetricsReportingEnabled()) {

+ if (MetricsServiceHelper::IsMetricsReportingEnabled(

+ g_browser_process->local_state())) {

ping_value += "&e=" + std::string(ping_data->is_enabled ? "1" : "0");

}

pings_[id].rollcall_days = ping_data->rollcall_days;