chrome/browser/extensions/updater/extension_downloader.cc - Issue 282093012: Remove dependencies of Metrics{Service,Log} on g_browser_process->local_state()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 282093012: Remove dependencies of Metrics{Service,Log} on g_browser_process->local_state() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove cruft Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/metrics_private/metrics_private_api.cc ('k') | chrome/browser/extensions/updater/manifest_fetch_data.cc » ('j') | chrome/browser/metrics/metrics_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/updater/extension_downloader.cc

diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc

index 612d0d095377adcdfeeeee996fb5acb9904dd2cd..b76255ad0fad3d8b40ad1fdc94fabe2edbbb46d4 100644

--- a/chrome/browser/extensions/updater/extension_downloader.cc

+++ b/chrome/browser/extensions/updater/extension_downloader.cc

@@ -20,6 +20,7 @@

#include "base/strings/stringprintf.h"

#include "base/time/time.h"

#include "base/version.h"

+#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/updater/extension_cache.h"

#include "chrome/browser/extensions/updater/request_queue_impl.h"

@@ -343,7 +344,8 @@ bool ExtensionDownloader::AddExtensionData(const std::string& id,

// If UMA is enabled, also add to ManifestFetchData for the

// webstore update URL.

if (!extension_urls::IsWebstoreUpdateUrl(update_url) &&

- MetricsServiceHelper::IsMetricsReportingEnabled()) {

+ MetricsServiceHelper::IsMetricsReportingEnabled(

+ g_browser_process->local_state())) {

update_urls.push_back(extension_urls::GetWebstoreUpdateUrl());

}