Reduce source file entries in a spellcheck build file.

Reduce source file entries in a spellcheck build file.

By including files as needed rather than excluding.

Review-Url: https://codereview.chromium.org/2820873003
Cr-Commit-Position: refs/heads/master@{#465344}
Committed: https://chromium.googlesource.com/chromium/src/+/3321cb342708eb6bddd41430fe14890a8590f22c

[Lei Zhang, 2017-04-15 04:48:09]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 04:48:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 06:01:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 06:01:29]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-18 04:52:07]

thestig@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2017-04-18 13:27:52]

LGTM

https://codereview.chromium.org/2820873003/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/BUILD.gn (right):

https://codereview.chromium.org/2820873003/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/BUILD.gn:36: if (!is_android) {
nit: Can these files be removed from Mac as well?

[Lei Zhang, 2017-04-18 18:46:37]

https://codereview.chromium.org/2820873003/diff/1/components/spellcheck/rende...
File components/spellcheck/renderer/BUILD.gn (right):

https://codereview.chromium.org/2820873003/diff/1/components/spellcheck/rende...
components/spellcheck/renderer/BUILD.gn:36: if (!is_android) {
On 2017/04/18 13:27:52, ಠ_ಠ wrote:
> nit: Can these files be removed from Mac as well?

Probably, but I'm strictly refactoring here. Maybe what you want after this is a
use_hunspell variable?

[please use gerrit instead, 2017-04-18 18:47:49]

On 2017/04/18 18:46:37, Lei Zhang wrote:
>
https://codereview.chromium.org/2820873003/diff/1/components/spellcheck/rende...
> File components/spellcheck/renderer/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2820873003/diff/1/components/spellcheck/rende...
> components/spellcheck/renderer/BUILD.gn:36: if (!is_android) {
> On 2017/04/18 13:27:52, ಠ_ಠ wrote:
> > nit: Can these files be removed from Mac as well?
> 
> Probably, but I'm strictly refactoring here. Maybe what you want after this is
a
> use_hunspell variable?

If it's strict refactor, then it's OK to submit as-is.

[Lei Zhang, 2017-04-18 18:52:34]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:53:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:13:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492541554644970, "parent_rev":
"1ba45d3d92c6d2907060c211c13736a5ee74c39f", "commit_rev":
"3321cb342708eb6bddd41430fe14890a8590f22c"}

[commit-bot: I haz the power, 2017-04-18 20:14:19]

Description was changed from

==========
Reduce source file entries in a spellcheck build file.

By including files as needed rather than excluding.
==========

to

==========
Reduce source file entries in a spellcheck build file.

By including files as needed rather than excluding.

Review-Url: https://codereview.chromium.org/2820873003
Cr-Commit-Position: refs/heads/master@{#465344}
Committed:
https://chromium.googlesource.com/chromium/src/+/3321cb342708eb6bddd41430fe14...
==========

[commit-bot: I haz the power, 2017-04-18 20:14:20]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3321cb342708eb6bddd41430fe14...