Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2820753004: Make gn_run_binary.py print out the exit code on error. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make gn_run_binary.py print out the exit code on error. Review-Url: https://codereview.chromium.org/2820753004 Cr-Commit-Position: refs/heads/master@{#464890} Committed: https://chromium.googlesource.com/chromium/src/+/b43ecb203b3ee459e3564e7957ab2cfbd2b040f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/gn_run_binary.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
vabr (Chromium)
LGTM, especially when I'm sheriff I would welcome this! Cheers, Vaclav
3 years, 8 months ago (2017-04-15 10:02:44 UTC) #4
Lei Zhang
+dpranke for OWNERS
3 years, 8 months ago (2017-04-15 21:31:13 UTC) #8
Lei Zhang
For context, we saw a mysterious bro.exe failure when compressing about_credits.html and there was nothing ...
3 years, 8 months ago (2017-04-15 21:33:23 UTC) #9
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-16 19:08:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820753004/1
3 years, 8 months ago (2017-04-16 20:36:17 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-16 21:40:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b43ecb203b3ee459e3564e7957ab...

Powered by Google App Engine
This is Rietveld 408576698