Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 282073003: Add return-by-value implementations of blink::WebMediaPlayer::buffered() (Closed)

Created:
6 years, 7 months ago by sandersd (OOO until July 31)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add return-by-value implementations of blink::WebMediaPlayer::buffered() This prep work will allow the interface in blink to be changed. Blink change is https://codereview.chromium.org/284143002/. BUG=360254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/media/buffered_data_source_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/buffered_data_source_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/pipeline.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
sandersd (OOO until July 31)
6 years, 7 months ago (2014-05-15 00:18:35 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 7 months ago (2014-05-15 18:35:28 UTC) #2
scherkus (not reviewing)
lgtm lgtm
6 years, 7 months ago (2014-05-15 18:35:28 UTC) #3
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 7 months ago (2014-05-15 18:46:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/282073003/1
6 years, 7 months ago (2014-05-15 18:47:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 21:39:17 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 00:05:38 UTC) #7
Message was sent while issue was closed.
Change committed as 270870

Powered by Google App Engine
This is Rietveld 408576698