content/renderer/media/buffered_data_source_host_impl.h - Issue 282073003: Add return-by-value implementations of blink::WebMediaPlayer::buffered()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/buffered_data_source_host_impl.h

Issue 282073003: Add return-by-value implementations of blink::WebMediaPlayer::buffered() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/buffered_data_source_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/buffered_data_source_host_impl.h

diff --git a/content/renderer/media/buffered_data_source_host_impl.h b/content/renderer/media/buffered_data_source_host_impl.h

index 301b08ea966b41dba852e2d675d6e90b35622497..d04d4671cc5ea216e38e525c8441beaed20071f0 100644

--- a/content/renderer/media/buffered_data_source_host_impl.h

+++ b/content/renderer/media/buffered_data_source_host_impl.h

@@ -25,9 +25,10 @@ class CONTENT_EXPORT BufferedDataSourceHostImpl

virtual void AddBufferedByteRange(int64 start, int64 end) OVERRIDE;

// Translate the byte ranges to time ranges and append them to the list.

+ // TODO(sandersd): This is a confusing name, find something better.

void AddBufferedTimeRanges(

media::Ranges<base::TimeDelta>* buffered_time_ranges,

- base::TimeDelta media_duration);

+ base::TimeDelta media_duration) const;

bool DidLoadingProgress();