|
|
Description[Extensions Bindings] Update webstore custom bindings
Webstore custom bindings do a one-off solution where the webstore API is
created without the use of the bindings system (i.e., it does not use
binding.Binding.generate()). Update these bindings to work with native
bindings (where it *will* use the bindings system).
BUG=653596
TEST=browser_tests --gtest_filter=Webstore*Installer* \
--native-crx-bindings=1
Review-Url: https://codereview.chromium.org/2820723002
Cr-Commit-Position: refs/heads/master@{#465454}
Committed: https://chromium.googlesource.com/chromium/src/+/1b1149ae47c1714427323a1d8e13bc0ae4309c1c
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : . #Patch Set 4 : Rebase #Messages
Total messages: 26 (21 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rdevlin.cronin@chromium.org changed reviewers: + lazyboy@chromium.org
lazyboy@, mind taking a look? I'm trying not to update all the custom bindings yet (in case stuff changes), but this one is a little more complex, and some of the changes are advantageous for the current system as well, so it seemed worthwhile. jbroman@, FYI.
lgtm https://codereview.chromium.org/2820723002/diff/20001/chrome/renderer/resourc... File chrome/renderer/resources/extensions/webstore_custom_bindings.js (right): https://codereview.chromium.org/2820723002/diff/20001/chrome/renderer/resourc... chrome/renderer/resources/extensions/webstore_custom_bindings.js:94: var apiFunctions = api.apiFunctions; Unused?
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2820723002/diff/20001/chrome/renderer/resourc... File chrome/renderer/resources/extensions/webstore_custom_bindings.js (right): https://codereview.chromium.org/2820723002/diff/20001/chrome/renderer/resourc... chrome/renderer/resources/extensions/webstore_custom_bindings.js:94: var apiFunctions = api.apiFunctions; On 2017/04/17 20:48:04, lazyboy wrote: > Unused? Whoops! Removed.
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org Link to the patchset: https://codereview.chromium.org/2820723002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492564088108400, "parent_rev": "ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49", "commit_rev": "1b1149ae47c1714427323a1d8e13bc0ae4309c1c"}
Message was sent while issue was closed.
Description was changed from ========== [Extensions Bindings] Update webstore custom bindings Webstore custom bindings do a one-off solution where the webstore API is created without the use of the bindings system (i.e., it does not use binding.Binding.generate()). Update these bindings to work with native bindings (where it *will* use the bindings system). BUG=653596 TEST=browser_tests --gtest_filter=Webstore*Installer* \ --native-crx-bindings=1 ========== to ========== [Extensions Bindings] Update webstore custom bindings Webstore custom bindings do a one-off solution where the webstore API is created without the use of the bindings system (i.e., it does not use binding.Binding.generate()). Update these bindings to work with native bindings (where it *will* use the bindings system). BUG=653596 TEST=browser_tests --gtest_filter=Webstore*Installer* \ --native-crx-bindings=1 Review-Url: https://codereview.chromium.org/2820723002 Cr-Commit-Position: refs/heads/master@{#465454} Committed: https://chromium.googlesource.com/chromium/src/+/1b1149ae47c1714427323a1d8e13... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/1b1149ae47c1714427323a1d8e13... |