Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2820713002: precache: Add the check for a minimum length of manifest bitset. (Closed)

Created:
3 years, 8 months ago by alexilin
Modified:
3 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

precache: Add the check for a minimum length of manifest bitset. Experiment bitsets have to be not shorter than manifest resource size. Manifests come from the network so it won't be paranoid to assert this condition. BUG=699115 Review-Url: https://codereview.chromium.org/2820713002 Cr-Commit-Position: refs/heads/master@{#465521} Committed: https://chromium.googlesource.com/chromium/src/+/132ccede61f0fe6fe34617a73eb945eb99ef1bee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M components/precache/core/precache_manifest_util.cc View 1 chunk +16 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
alexilin
3 years, 8 months ago (2017-04-14 16:03:18 UTC) #2
Benoit L
On 2017/04/14 16:03:18, alexilin wrote: lgtm
3 years, 8 months ago (2017-04-18 16:16:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820713002/1
3 years, 8 months ago (2017-04-19 07:04:51 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 07:48:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/132ccede61f0fe6fe34617a73eb9...

Powered by Google App Engine
This is Rietveld 408576698