Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: ios/clean/chrome/browser/ui/root/root_coordinator.mm

Issue 2820703002: Remove code in subclasses already performed by the base class. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/root/root_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/root/root_coordinator.mm b/ios/clean/chrome/browser/ui/root/root_coordinator.mm
index af9bb884351e72dd9db8b64c58fbee2593d64f88..289e27006cdb07dc53f1c07ed459348a8aa7a3b9 100644
--- a/ios/clean/chrome/browser/ui/root/root_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/root/root_coordinator.mm
@@ -41,10 +41,9 @@
- (void)stop {
marq (ping after 24h) 2017/04/18 12:13:26 can this whole method go away now?
lpromero 2017/05/03 13:13:23 No, to balance in stop the child coordinators addi
[super stop];
- // PLACEHOLDER: Stop child coordinators here for now. We might deal with this
+ // PLACEHOLDER: Remove child coordinators here for now. This might be handled
// differently later on.
for (BrowserCoordinator* child in self.children) {
- [child stop];
[self removeChildCoordinator:child];
}
}

Powered by Google App Engine
This is Rietveld 408576698