Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm

Issue 2820703002: Remove code in subclasses already performed by the base class. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
index 1962c7aa015a3bdd92cd0cb4bccce53905da5717..d6bfc4719d75412fd4145d277dbab65a7b9fa63d 100644
--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_coordinator.mm
@@ -86,8 +86,9 @@
[super stop];
[self.browser->dispatcher() stopDispatchingToTarget:self];
[self.mediator disconnect];
+ // PLACEHOLDER: Remove child coordinators here for now. This might be handled
+ // differently later on.
for (BrowserCoordinator* child in self.children) {
marq (ping after 24h) 2017/04/18 12:13:26 Update this for coordinator changes?
lpromero 2017/05/03 13:13:23 Was this comment the same as the previous one? Oth
marq (ping after 24h) 2017/05/03 13:17:49 I thought we were handling this (removing children
lpromero 2017/05/03 13:20:54 We stop childrens in the parent's stop, but we onl
- [child stop];
[self removeChildCoordinator:child];
}
}

Powered by Google App Engine
This is Rietveld 408576698