Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2820693005: Remove "Searching for Wi-Fi networks..." message. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "Searching for Wi-Fi networks..." message. Context is deemed to be enough to determine what the progress bar means. BUG=701740 Review-Url: https://codereview.chromium.org/2820693005 Cr-Commit-Position: refs/heads/master@{#465370} Committed: https://chromium.googlesource.com/chromium/src/+/5302a09f65c3e01387ba0397b766c7dda29119b4

Patch Set 1 #

Patch Set 2 : restore string resource for the sake of login code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M ash/system/network/network_state_list_detailed_view.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Evan Stade
3 years, 8 months ago (2017-04-14 22:43:40 UTC) #2
tdanderson
lgtm
3 years, 8 months ago (2017-04-18 18:46:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820693005/1
3 years, 8 months ago (2017-04-18 20:13:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/321831) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 8 months ago (2017-04-18 20:27:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820693005/20001
3 years, 8 months ago (2017-04-18 20:31:31 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:00:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5302a09f65c3e01387ba0397b766...

Powered by Google App Engine
This is Rietveld 408576698