Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2820653002: Open the settings tab in the message center when clicking the settings button on a notification. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Open the settings tab in the message center when clicking the settings button on a notification. Before this change, clicking the settings button on a notification opens the notification section in the settings window (chrome://settings) BUG=706658 Review-Url: https://codereview.chromium.org/2799653004 Cr-Commit-Position: refs/heads/master@{#462815} (cherry picked from commit f7d02d633ab7cb42632521709869212cdca3a835) Review-Url: https://codereview.chromium.org/2820653002 . Cr-Commit-Position: refs/branch-heads/3029@{#706} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/58b36a73de145bb4e1ae45f369dd43f7bbb2f252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
yhanada
3 years, 8 months ago (2017-04-14 04:24:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58b36a73de145bb4e1ae45f369dd43f7bbb2f252.

Powered by Google App Engine
This is Rietveld 408576698