Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2820573005: dart2js: --fast-startup: share defaultValues property for closures with no default values (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: --fast-startup: share defaultValues property for closures with no default values R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/cdba92a563128bb4febcdf94270b761c23401067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
sra1
3 years, 8 months ago (2017-04-17 16:40:11 UTC) #5
Siggi Cherem (dart-lang)
lgtm
3 years, 8 months ago (2017-04-17 16:46:15 UTC) #6
sra1
3 years, 8 months ago (2017-04-17 17:27:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
cdba92a563128bb4febcdf94270b761c23401067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698