dart2js: --fast-startup: share defaultValues property for closures with no default values

pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.js_emitter.program_builder;
 
 import '../../closure.dart' show ClosureFieldElement;
 import '../../common.dart';
 import '../../common/names.dart' show Names, Selectors;
 import '../../compiler.dart' show Compiler;
@@ skipping 484 matching lines @@
   }
 
   Class _buildClass(ClassElement element) {
     bool onlyForRti = collector.classesOnlyNeededForRti.contains(element);
     bool hasRtiField = backend.rtiNeed.classNeedsRtiField(element);
     if (backend.nativeData.isJsInteropClass(element)) {
       // TODO(jacobr): check whether the class has any active static fields
       // if it does not we can suppress it completely.
       onlyForRti = true;
     }
+    bool isClosureBaseClass = element == _compiler.commonElements.closureClass;
 
     List<Method> methods = [];
     List<StubMethod> callStubs = <StubMethod>[];
 
     ClassStubGenerator classStubGenerator = new ClassStubGenerator(
         namer, backend, worldBuilder, closedWorld,
         enableMinification: _compiler.options.enableMinification);
     RuntimeTypeGenerator runtimeTypeGenerator =
         new RuntimeTypeGenerator(_compiler, _task, namer);
 
@@ skipping 29 matching lines @@
         String selectorName = selector.name;
         if (selector.isSetter) selectorName = "$selectorName=";
         if (backend.mirrorsData.symbolsUsed.contains(selectorName)) {
           _symbolsMap[name] = selectorName;
         }
         noSuchMethodStubs.add(
             classStubGenerator.generateStubForNoSuchMethod(name, selector));
       });
     }
 
-    if (element == _compiler.commonElements.closureClass) {
-      // We add a special getter here to allow for tearing off a closure from
-      // itself.
+    if (isClosureBaseClass) {
+      // We add a special getter to allow for tearing off a closure from itself.
       js.Name name = namer.getterForMember(Names.call);
       js.Fun function = js.js('function() { return this; }');
       callStubs.add(_buildStubMethod(name, function));
     }
 
     ClassElement implementation = element.implementation;
 
     // MixinApplications run through the members of their mixin. Here, we are
     // only interested in direct members.
     if (!onlyForRti && !element.isMixinApplication) {
@@ skipping 43 matching lines @@
     // TODO(floitsch): we shouldn't update the registry in the middle of
     // building a class.
     Holder holder = _registry.registerHolder(holderName);
     bool isInstantiated = !backend.nativeData.isJsInteropClass(element) &&
         worldBuilder.directlyInstantiatedClasses.contains(element);
 
     Class result;
     if (element.isMixinApplication && !onlyForRti) {
       assert(!backend.nativeData.isNativeClass(element));
       assert(methods.isEmpty);
+      assert(!isClosureBaseClass);
 
       result = new MixinApplication(
           element,
           name,
           holder,
           instanceFields,
           staticFieldsForReflection,
           callStubs,
           checkedSetters,
           isChecks,
@@ skipping 10 matching lines @@
           instanceFields,
           staticFieldsForReflection,
           callStubs,
           noSuchMethodStubs,
           checkedSetters,
           isChecks,
           typeTests.functionTypeIndex,
           isDirectlyInstantiated: isInstantiated,
           hasRtiField: hasRtiField,
           onlyForRti: onlyForRti,
-          isNative: backend.nativeData.isNativeClass(element));
+          isNative: backend.nativeData.isNativeClass(element),
+          isClosureBaseClass: isClosureBaseClass);
     }
     _classes[element] = result;
     return result;
   }
 
   bool _methodNeedsStubs(FunctionElement method) {
     return !method.functionSignature.optionalParameters.isEmpty;
   }
 
   bool _methodCanBeReflected(MethodElement method) {
@@ skipping 310 matching lines @@
       Constant constant = new Constant(name, holder, constantValue);
       _constants[constantValue] = constant;
     }
   }
 
   Holder _registerStaticStateHolder() {
     return _registry.registerHolder(namer.staticStateHolder,
         isStaticStateHolder: true);
   }
 }