apps/ui/views/BUILD.gn - Issue 2820563004: Create separate BUILD.gn for //apps/ui/views

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/ui/views/BUILD.gn

Issue 2820563004: Create separate BUILD.gn for //apps/ui/views (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/ui.gni")

	6 import("//extensions/features/features.gni")

	7

	8 assert(enable_extensions)
	michaelpg 2017/05/22 23:15:41 Is this the part that caused problems when compili Is this the part that caused problems when compiling? What gn args are you using? hugoh_UTC2 2017/05/23 11:57:27 Yes, this assert (and some others of the same kind Show quoted text On 2017/05/22 23:15:41, michaelpg wrote: > Is this the part that caused problems when compiling? What gn args are you > using? Yes, this assert (and some others of the same kind) fails when we build with enable_extensions=false. I've uploaded fixes for this at https://codereview.chromium.org/2904443004 - let's continue the discussion there! :)
	9

	10 source_set("views") {

	11 sources = [

	12 "app_window_frame_view.cc",

	13 "app_window_frame_view.h",

	14 ]

	15

	16 deps = [

	17 "//cc/paint",

	18 "//chrome/app/theme:theme_resources",

	19 "//extensions/browser/app_window",

	20 "//extensions/common",

	21 "//skia",

	22 "//ui/gfx",

	23 "//ui/strings",

	24 "//ui/views",

	25 ]

	26 }

OLD	NEW

« apps/BUILD.gn ('K') | « apps/DEPS ('k') | apps/ui/views/DEPS » ('j') | no next file with comments »