Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2820563002: Mark layout test for Skia change. (Closed)

Created:
3 years, 8 months ago by bungeman-chromium
Modified:
3 years, 8 months ago
Reviewers:
drott, f(malita), eae
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark layout test for Skia change. An anticipated Skia change will affect the rendering of the fast/text/ellipsis-platform-font-change.html layout test. This is an expected change, and will be rebaselined after the Skia change lands in Chromium. BUG=706792 Review-Url: https://codereview.chromium.org/2820563002 Cr-Commit-Position: refs/heads/master@{#464472} Committed: https://chromium.googlesource.com/chromium/src/+/9940950d3b60fec596ec8e9a6586a26c97861d96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
bungeman-chromium
The Skia cl is https://skia-review.googlesource.com/c/11400/ as mentioned in the CL itself. The diff is at ...
3 years, 8 months ago (2017-04-13 17:04:30 UTC) #4
f(malita)
lgtm
3 years, 8 months ago (2017-04-13 17:09:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820563002/1
3 years, 8 months ago (2017-04-13 17:22:52 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 18:19:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9940950d3b60fec596ec8e9a6586...

Powered by Google App Engine
This is Rietveld 408576698