Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2820553003: [wasm] Add a flag to enable/disable async compile. (Closed)

Created:
3 years, 8 months ago by bradnelson
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com, Michael Hablich
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a flag to enable/disable async compile. Adding a flag to explicitly enable/disable async compile. Will cherrypick this to M59. Separately will land a change to re-enable this by default. BUG=v8:6264 R=mtrofin@chromium.org,ahaas@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2820553003 Cr-Commit-Position: refs/heads/master@{#44653} Committed: https://chromium.googlesource.com/v8/v8/+/07aea4421b6e9e1113f5f90c73b38963fcee8d81

Patch Set 1 #

Patch Set 2 : [wasm] Add a flag to enable/disable async compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
bradn
3 years, 8 months ago (2017-04-13 19:04:27 UTC) #4
Mircea Trofin
On 2017/04/13 19:04:27, bradn wrote: lgtm
3 years, 8 months ago (2017-04-13 19:05:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820553003/20001
3 years, 8 months ago (2017-04-13 19:07:08 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 19:39:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/07aea4421b6e9e1113f5f90c73b38963fce...

Powered by Google App Engine
This is Rietveld 408576698