Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: include/utils/SkJSONCPP.h

Issue 282053002: Generate bench/Android.mk from gyp. (Closed) Base URL: https://skia.googlesource.com/skia.git@baselines
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/utils/SkJSONCPP.h
diff --git a/include/utils/SkJSONCPP.h b/include/utils/SkJSONCPP.h
index 8dbb40c91bedfa3c52a56415a9e041a030a58a28..da11eb44f6cf26047665189c7ed7d0a357967a79 100644
--- a/include/utils/SkJSONCPP.h
+++ b/include/utils/SkJSONCPP.h
@@ -10,6 +10,10 @@
#ifndef SkJSONCPP_DEFINED
#define SkJSONCPP_DEFINED
+// FIXME (scroggo): JSON is disabled in Android framework until we solve
+// skbug.com/2448
+#ifndef SK_BUILD_FOR_ANDROID_FRAMEWORK
+
hal.canary 2014/05/15 14:29:36 Can we just not include this file? #ifdef SK_BUIL
scroggo 2014/05/15 20:00:54 As stated elsewhere, I think it's simpler to inclu
#ifdef SK_BUILD_FOR_WIN
// json includes xlocale which generates warning 4530 because we're
// compiling without exceptions;
@@ -23,4 +27,6 @@
#pragma warning(pop)
#endif
+#endif // SK_BUILD_FOR_ANDROID_FRAMEWORK
+
#endif

Powered by Google App Engine
This is Rietveld 408576698